Bug 103558

Summary: Allow clients to ask for the WebView/WKView placeholder view when in full screen mode.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Jer Noble
Reported 2012-11-28 13:33:53 PST
Add SPI to allow clients to ask for a WebView/WKView placeholder view in full scren.
Attachments
Patch (6.93 KB, patch)
2012-11-28 13:40 PST, Jer Noble 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2012-11-28 13:40:39 PST
Created attachment 176563 [details] Patch
Benjamin Poulain
Comment 2 2013-01-29 12:22:03 PST
Comment on attachment 176563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176563&action=review This is very unfortunate, but I don't see a cleaner solution, especially for WebKit1. :( For WebKit2, IMHO, we should keep the same NSView in place, and use a new view to present the content in fullscreen. Since the WebKit layer is disconnected from the NSView, we can theoretically move the backend to a new view. > Source/WebKit/mac/ChangeLog:4 > + Allow clients to ask for the WebView/WKView placeholder view when in full screen mode. > + https://bugs.webkit.org/show_bug.cgi?id=103558 It would be good to provide the radar number in the ChangeLog for future reference. This radar is pretty good.
Jer Noble
Comment 3 2013-01-29 15:56:36 PST
Committed r141173: <http://trac.webkit.org/changeset/141173>
Note You need to log in before you can comment on or make changes to this bug.