Bug 103550

Summary: Web Inspector: Make main-thread monitoring go through InspectorController
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, caseq, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 103695    
Bug Blocks: 103120    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+, webkit.review.bot: commit-queue-

Eugene Klyuchnikov
Reported 2012-11-28 12:26:12 PST
Actually InspectorInstrumentation itself filters instrumentation calls.
Attachments
Patch (15.07 KB, patch)
2012-11-29 10:55 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (15.46 KB, patch)
2012-11-30 12:09 PST, Eugene Klyuchnikov 		pfeldman: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2012-11-29 10:55:41 PST
Created attachment 176761 [details] Patch
WebKit Review Bot
Comment 2 2012-11-29 10:57:54 PST
Attachment 176761 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/src/InspectorClientImpl.h:46: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:70: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:71: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2012-11-29 15:08:15 PST
Comment on attachment 176761 [details] Patch Clearing flags on attachment: 176761 Committed r136171: <http://trac.webkit.org/changeset/136171>
WebKit Review Bot
Comment 4 2012-11-29 15:08:18 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2012-11-29 17:38:32 PST
Re-opened since this is blocked by bug 103695
Eugene Klyuchnikov
Comment 6 2012-11-30 12:09:20 PST
Created attachment 177004 [details] Patch
WebKit Review Bot
Comment 7 2012-11-30 12:12:25 PST
Attachment 177004 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/src/InspectorClientImpl.h:46: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:70: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/chromium/src/WebDevToolsAgentImpl.h:71: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 8 2012-12-03 11:09:10 PST
Comment on attachment 177004 [details] Patch Rejecting attachment 177004 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ripts/update-webkit line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit 1db1bee..cce9e2a HEAD -> origin/HEAD error: Ref refs/remotes/origin/master is at cce9e2ab4c4544da56392b8fc08797434f12b9b3 but expected 1db1bee680414c2b5d10e6b820eb7c7e89858e47 ! 1db1bee..cce9e2a master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15100609
Andrey Kosyakov
Comment 9 2012-12-03 12:05:05 PST
Committed r136426: <http://trac.webkit.org/changeset/136426>
Note You need to log in before you can comment on or make changes to this bug.