Bug 103546

Summary: Report CSS as initiator instead of elements, except body
Product: WebKit Reporter: James Simonsen <simonjam>
Component: New BugsAssignee: James Simonsen <simonjam>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, dglazkov, jochen, macpherson, marja, menard, ojan, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

James Simonsen
Reported 2012-11-28 12:01:22 PST
Report CSS as initiator instead of elements, except body
Attachments
Patch (7.22 KB, patch)
2012-11-28 12:06 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (9.30 KB, patch)
2012-11-29 15:42 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2012-11-28 12:06:58 PST
Created attachment 176537 [details] Patch
James Simonsen
Comment 2 2012-11-28 12:08:01 PST
I checked with Marja over e-mail. It sounds like this is okay, but I wanted to double check before we land this.
WebKit Review Bot
Comment 3 2012-11-28 13:56:50 PST
Comment on attachment 176537 [details] Patch Attachment 176537 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15026560 New failing tests: platform/chromium/fast/loader/resource-request-callbacks.html
Marja Hölttä
Comment 4 2012-11-29 00:38:35 PST
Yup, afaics this makes sense for our use case (notifying the embedder when resources are requested) too. E.g., for CSS initiating image loads, we'd anyway need to do something to all elements which would get the image from the CSS, and making one of those elements the initiator doesn't help. (The test needs to be updated though, but it's ok.)
James Simonsen
Comment 5 2012-11-29 15:42:57 PST
Created attachment 176836 [details] Patch
WebKit Review Bot
Comment 6 2012-11-30 11:20:37 PST
Comment on attachment 176836 [details] Patch Clearing flags on attachment: 176836 Committed r136256: <http://trac.webkit.org/changeset/136256>
WebKit Review Bot
Comment 7 2012-11-30 11:20:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.