Bug 103545

Summary: Web Inspector: introduce fast case for within-chunk edit
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 103762    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Pavel Feldman
Reported 2012-11-28 12:00:47 PST
Otherwise we rebuild entire chunk upon any input event.
Attachments
Patch (4.04 KB, patch)
2012-11-28 13:59 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-11-28 13:59:32 PST
Created attachment 176570 [details] Patch
Vsevolod Vlasov
Comment 2 2012-11-29 10:24:30 PST
Comment on attachment 176570 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176570&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2424 > + var lastUndamagedLineRow = lastDamagedChunk.expandedLineRow(oldRange.startLine - 1); s/lastDamagedChunk/firstDamagedChunk/ for consistency > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2434 > + firstDamagedChunk.updateCollapsedLineRow(); This could be done lazily, do you intend change that later?
Pavel Feldman
Comment 3 2012-11-29 11:34:38 PST
> This could be done lazily, do you intend change that later? Yep
WebKit Review Bot
Comment 4 2012-11-29 12:07:28 PST
Comment on attachment 176570 [details] Patch Clearing flags on attachment: 176570 Committed r136145: <http://trac.webkit.org/changeset/136145>
WebKit Review Bot
Comment 5 2012-11-29 12:07:31 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2012-11-30 12:26:24 PST
Re-opened since this is blocked by bug 103762
Note You need to log in before you can comment on or make changes to this bug.