Bug 103495

Summary:

[EFL][WK2][AC] Clear the viewport with white color

Product:

WebKit

Reporter:

Joone Hur <joone>

Component:

WebKit EFL

Assignee:

Joone Hur <joone>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, d-r, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot, yael

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Joone Hur

Reported 2012-11-28 02:08:02 PST

When we run MiniBrowser, the default viewport color is black. We need to change the color with white.

Attachments
Patch (1.46 KB, patch) 2012-11-28 03:48 PST, Joone Hur	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joone Hur

Comment 1 2012-11-28 03:48:33 PST

Created attachment 176448 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2012-11-28 03:58:17 PST

Comment on attachment 176448 [details] Patch Wouldn't transparent not be better?

Joone Hur

Comment 3 2012-11-28 04:34:55 PST

(In reply to comment #2) > (From update of attachment 176448 [details]) > Wouldn't transparent not be better? Yes, maybe. I checked the gtk+ port. It also clears the buffer with white color like this. http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp#L300

Kenneth Rohde Christiansen

Comment 4 2012-11-28 04:39:25 PST

Sure but we are a mobile port and it should be possible to pan/pinch contents out of bounds and then have it bounce back again. In that case we don't want to show just white but be able to see the browser background below. You can try the Qt MiniBrowser if you want to get an understanding of this. Maybe Thiago can show you, or you can try on an N9.

WebKit Review Bot

Comment 5 2012-11-28 04:46:41 PST

Comment on attachment 176448 [details] Patch Clearing flags on attachment: 176448 Committed r135997: <http://trac.webkit.org/changeset/135997>

WebKit Review Bot

Comment 6 2012-11-28 04:46:45 PST

All reviewed patches have been landed. Closing bug.

Joone Hur

Comment 7 2012-11-28 05:23:31 PST

(In reply to comment #4) > Sure but we are a mobile port and it should be possible to pan/pinch contents out of bounds and then have it bounce back again. In that case we don't want to show just white but be able to see the browser background below. > > You can try the Qt MiniBrowser if you want to get an understanding of this. Maybe Thiago can show you, or you can try on an N9. I'm not sure if all mobile browsers should have the same effect. By the way, isn't this bounce effect an Apple patent?

Note You need to log in before you can comment on or make changes to this bug.