Bug 103489

Summary: Merge tests for date pseudo classes into one
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gyuyoung.kim, haraken, morrita, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103602    
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2012-11-27 23:26:33 PST
Merge tests for date pseudo classes into one
Attachments
Patch (142.32 KB, patch)
2012-11-27 23:34 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-11-27 23:34:13 PST
Created attachment 176411 [details] Patch
WebKit Review Bot
Comment 2 2012-11-28 00:17:48 PST
Comment on attachment 176411 [details] Patch Attachment 176411 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15000940 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html
Kentaro Hara
Comment 3 2012-11-28 00:26:07 PST
Comment on attachment 176411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176411&action=review ok > LayoutTests/fast/forms/date/date-pseudo-classes.html:31 > +document.getElementById('outofrange').value = '1500-01-01'; Just to confirm: 1500-01-01 is not out-of-range (so this test is equivalent to the removed test for 2010-12-28), right?
Kent Tamura
Comment 4 2012-11-28 01:00:25 PST
Comment on attachment 176411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176411&action=review >> LayoutTests/fast/forms/date/date-pseudo-classes.html:31 >> +document.getElementById('outofrange').value = '1500-01-01'; > > Just to confirm: 1500-01-01 is not out-of-range (so this test is equivalent to the removed test for 2010-12-28), right? absolutely right.
WebKit Review Bot
Comment 5 2012-11-28 02:06:22 PST
Comment on attachment 176411 [details] Patch Clearing flags on attachment: 176411 Committed r135989: <http://trac.webkit.org/changeset/135989>
WebKit Review Bot
Comment 6 2012-11-28 02:06:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.