Bug 103474

Summary: [Refactoring] HasSelectorForClassStyleFunctor in Element.cpp seems verbose
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Shinya Kawanaka <shinyak>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, koivisto, ojan, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 100738    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-11-27 18:04:01 PST
This is a follow-up bug for Bug 100738. The added code seems verbose, so let's make it simple.
Attachments
Patch (7.06 KB, patch)
2012-11-27 19:01 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (7.08 KB, patch)
2012-11-27 20:14 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-11-27 19:01:02 PST
Created attachment 176384 [details] Patch
Hajime Morrita
Comment 2 2012-11-27 19:02:19 PST
Comment on attachment 176384 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176384&action=review > Source/WebCore/dom/Element.cpp:839 > +template<typename T> Could you give more descriptive name instead of T?
Shinya Kawanaka
Comment 3 2012-11-27 20:14:55 PST
Created attachment 176387 [details] Patch
WebKit Review Bot
Comment 4 2012-11-27 20:38:09 PST
Comment on attachment 176387 [details] Patch Clearing flags on attachment: 176387 Committed r135967: <http://trac.webkit.org/changeset/135967>
WebKit Review Bot
Comment 5 2012-11-27 20:38:14 PST
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 6 2012-11-28 02:52:24 PST
Much better!
Note You need to log in before you can comment on or make changes to this bug.