Summary: | Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, levin+watchlist, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zan Dobersek
2012-11-27 07:00:23 PST
Created attachment 176261 [details]
Patch
Comment on attachment 176261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176261&action=review lgtm (mostly a rubber-stamp). > Tools/Scripts/webkitpy/tool/commands/queues_unittest.py:413 > +bar/baz-diffs.txt does not exist in results archive, uploading entire archive. I wonder where this line comes in from ... ? Comment on attachment 176261 [details] Patch Clearing flags on attachment: 176261 Committed r135912: <http://trac.webkit.org/changeset/135912> All reviewed patches have been landed. Closing bug. Comment on attachment 176261 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176261&action=review >> Tools/Scripts/webkitpy/tool/commands/queues_unittest.py:413 >> +bar/baz-diffs.txt does not exist in results archive, uploading entire archive. > > I wonder where this line comes in from ... ? It was always there, but was reported through the Logger in flakytestreporter.py[1]. Until now this unit test only checked expected stderr output, but the output was now moved into log form where this line also pops up. [1] http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py#L169 |