Bug 103401

Summary: Inline ImageFrame width() and height()
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: ImagesAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88424    
Attachments:
Description Flags
Patch none

noel gordon
Reported 2012-11-27 05:01:04 PST
Per https://bugs.webkit.org/show_bug.cgi?id=88424#c38, we should inline ImageFrame width() and height().
Attachments
Patch (3.55 KB, patch)
2012-11-27 05:20 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2012-11-27 05:20:39 PST
Created attachment 176241 [details] Patch
Brent Fulgham
Comment 2 2012-11-27 21:21:53 PST
Comment on attachment 176241 [details] Patch Looks great. r=me.
WebKit Review Bot
Comment 3 2012-11-27 21:25:03 PST
Comment on attachment 176241 [details] Patch Clearing flags on attachment: 176241 Committed r135971: <http://trac.webkit.org/changeset/135971>
WebKit Review Bot
Comment 4 2012-11-27 21:25:05 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2012-11-27 23:42:20 PST
Comment on attachment 176241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review > Source/WebCore/platform/image-decoders/ImageDecoder.h:199 > + return m_size.width(); Oh oh. Should be height, not width. This is causing a lot of failures.
Brent Fulgham
Comment 6 2012-11-27 23:44:04 PST
Comment on attachment 176241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review >> Source/WebCore/platform/image-decoders/ImageDecoder.h:199 >> + return m_size.width(); > > Oh oh. Should be height, not width. This is causing a lot of failures. Doh! How did I miss this. :-( Mea culpa.
Zan Dobersek
Comment 7 2012-11-28 00:07:45 PST
(In reply to comment #5) > (From update of attachment 176241 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176241&action=review > > > Source/WebCore/platform/image-decoders/ImageDecoder.h:199 > > + return m_size.width(); > > Oh oh. Should be height, not width. This is causing a lot of failures. Just to address this, it has been fixed in r135980. http://trac.webkit.org/changeset/135980
Note You need to log in before you can comment on or make changes to this bug.