Bug 103398

Summary:

OpenCL version of FEColorMatrix

Product:

WebKit

Reporter:

Tamas Czene <tczene>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, webkit.review.bot, zherczeg, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

70099

Bug Blocks:

Attachments:

Description	Flags
draft patch	none
proposed patch	zherczeg: review-, zherczeg: commit-queue-
svg file	none
proposed patch	none

Tamas Czene

Reported 2012-11-27 04:41:12 PST

FEColorMatrix filter need to be implemented on OpenCL.

Attachments
draft patch (11.90 KB, patch) 2012-11-27 23:42 PST, Tamas Czene	no flags	Details Formatted Diff Diff
proposed patch (15.47 KB, patch) 2012-12-11 08:03 PST, Tamas Czene	zherczeg: review- zherczeg: commit-queue-	Details Formatted Diff Diff
svg file (1.37 KB, image/svg+xml) 2012-12-11 23:57 PST, Tamas Czene	no flags	Details
proposed patch (15.45 KB, patch) 2012-12-13 04:22 PST, Tamas Czene	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Tamas Czene

Comment 1 2012-11-27 23:42:58 PST

Created attachment 176413 [details] draft patch

Tamas Czene

Comment 2 2012-12-11 08:03:38 PST

Created attachment 178807 [details] proposed patch Benchmark results: Qt Linux: GPU: NVIDIA GeForce GT 440 CUDA Cores 96 CPU: Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz 4 Core Software: 3 fps OpenCL GPU: 15 fps

Zoltan Herczeg

Comment 3 2012-12-11 09:51:26 PST

Could you attach the source code of the benchmark as well?

Tamas Czene

Comment 4 2012-12-11 23:57:26 PST

Created attachment 178983 [details] svg file

Zoltan Herczeg

Comment 5 2012-12-13 00:53:16 PST

Comment on attachment 178807 [details] proposed patch The patch looks good, only a few changes: View in context: https://bugs.webkit.org/attachment.cgi?id=178807&action=review > Source/WebCore/ChangeLog:4 > + OpenCL version of FEColorMatrix. > + https://bugs.webkit.org/show_bug.cgi?id=103398 Where is the "revewed by" line? > Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:52 > + values[5] * sourcePixel.x + values[6] * sourcePixel.y + values[7] * sourcePixel.z + values[8] * sourcePixel.w + values[9], > + values[10] * sourcePixel.x + values[11] * sourcePixel.y + values[12] * sourcePixel.z + values[13] * sourcePixel.w + values[14], > + values[15] * sourcePixel.x + values[16] * sourcePixel.y + values[17] * sourcePixel.z + values[18] * sourcePixel.w + values[19]) +4 space indentation > Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:60 > + sourcePixel.x * components[3] + sourcePixel.y * components[4] + sourcePixel.z * components[5], > + sourcePixel.x * components[6] + sourcePixel.y * components[7] + sourcePixel.z * components[8], > + sourcePixel.w) ditto. > Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:112 > + colorMatrix = 0; return. 0 is an invalid value. And an ASSERT_NOT_REACHED() > Source/WebCore/platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:141 > + absolutePaintRect().x() - in->absolutePaintRect().location().x(), > + absolutePaintRect().y() - in->absolutePaintRect().location().y()); Indentation again.

Tamas Czene

Comment 6 2012-12-13 04:22:30 PST

Created attachment 179248 [details] proposed patch

Zoltan Herczeg

Comment 7 2012-12-13 06:47:03 PST

Comment on attachment 179248 [details] proposed patch r=me nice patch.

WebKit Review Bot

Comment 8 2012-12-13 07:07:43 PST

Comment on attachment 179248 [details] proposed patch Clearing flags on attachment: 179248 Committed r137591: <http://trac.webkit.org/changeset/137591>

WebKit Review Bot

Comment 9 2012-12-13 07:07:47 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.