Bug 103391

Summary: [V8] Replace toWebCoreString()/toWebCoreAtomicString() in CodeGeneratorV8.pm with V8StringResource
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103331    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-11-27 04:23:18 PST
This is an incremental effort for fixing bug 103331.
Attachments
Patch (7.22 KB, patch)
2012-11-27 04:25 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-11-27 04:25:15 PST
Created attachment 176230 [details] Patch
WebKit Review Bot
Comment 2 2012-11-27 14:30:34 PST
Comment on attachment 176230 [details] Patch Clearing flags on attachment: 176230 Committed r135922: <http://trac.webkit.org/changeset/135922>
WebKit Review Bot
Comment 3 2012-11-27 14:30:38 PST
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 4 2012-11-27 16:19:37 PST
By this change, all value conversions in generated code are already surrounded by TRYCATCH() blocks correctly. On the other hand, a huge amount of value conversions in custom bindings are missing TRYCATCH() blocks, which we want to fix at some point.
Note You need to log in before you can comment on or make changes to this bug.