Bug 103391

Summary:

[V8] Replace toWebCoreString()/toWebCoreAtomicString() in CodeGeneratorV8.pm with V8StringResource

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebCore JavaScript

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

103331

Attachments:

Description	Flags
Patch	none

Description Kentaro Hara 2012-11-27 04:23:18 PST

This is an incremental effort for fixing bug 103331.

Comment 1 Kentaro Hara 2012-11-27 04:25:15 PST

Created attachment 176230 [details]
Patch

Comment 2 WebKit Review Bot 2012-11-27 14:30:34 PST

Comment on attachment 176230 [details]
Patch

Clearing flags on attachment: 176230

Committed r135922: <http://trac.webkit.org/changeset/135922>

Comment 3 WebKit Review Bot 2012-11-27 14:30:38 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Kentaro Hara 2012-11-27 16:19:37 PST

By this change, all value conversions in generated code are already surrounded by TRYCATCH() blocks correctly. On the other hand, a huge amount of value conversions in custom bindings are missing TRYCATCH() blocks, which we want to fix at some point.