Summary: | PDFPlugin: Should not be able to edit read-only text annotations | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
Component: | Assignee: | Tim Horton <thorton> | |||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, mitz, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tim Horton
2012-11-27 03:19:17 PST
Created attachment 176219 [details]
patch
It is very rare for create() to do anything besides wrapping a constructor. I'm not sure if this is the best place to have such logic. (In reply to comment #2) > It is very rare for create() to do anything besides wrapping a constructor. I'm not sure if this is the best place to have such logic. OK, I'll move it earlier. Created attachment 176370 [details]
patch
Attachment 176370 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/Plugins/PDF/PDFAnnotationTextWidgetDetails.h:28: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Thanks, Alexey! http://trac.webkit.org/changeset/135958 |