Bug 103370

Summary: [Refactoring] NodeFlags::IsShadowRootFlag should be Node::IsDocumentFragmentFlag
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103372    
Bug Blocks:    
Attachments:
Description Flags
Patch haraken: review+

Hajime Morrita
Reported 2012-11-27 00:00:43 PST
DocumentFragment check is on a hot path and can be done by a node flag check.
Attachments
Patch (6.20 KB, patch)
2012-11-27 00:28 PST, Hajime Morrita
haraken: review+
Hajime Morrita
Comment 1 2012-11-27 00:28:19 PST
Kentaro Hara
Comment 2 2012-11-27 00:43:06 PST
Comment on attachment 176191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176191&action=review r+ing assuming that the perf impact on isShadowRoot()==true is acceptable. > Source/WebCore/ChangeLog:8 > + This chagne introduces Node::IsDocumentFragmentFlag so that we can Typo: change.
Hajime Morrita
Comment 3 2012-11-27 00:51:28 PST
Note You need to log in before you can comment on or make changes to this bug.