Bug 103358

Summary: Entering Tab View after a bunch of YouTube pages were opened in background tabs makes all of them start playing simultaneously
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, hausmann, ossy, tmpsantos, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103388    
Bug Blocks:    
Attachments:
Description Flags
Add WKPageSetMayStartMediaWhenInWindow none

mitz
Reported 2012-11-26 21:44:40 PST
Entering Tab View after a bunch of YouTube pages were opened in background tabs makes all of them start playing simultaneously
Attachments
Add WKPageSetMayStartMediaWhenInWindow (10.12 KB, patch)
2012-11-26 21:58 PST, mitz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2012-11-26 21:47:33 PST
<rdar://problem/11931191> To fix this, there needs to be API for preventing the normal behavior of media starting when a view is in a window.
mitz
Comment 2 2012-11-26 21:58:04 PST
Created attachment 176169 [details] Add WKPageSetMayStartMediaWhenInWindow
mitz
Comment 3 2012-11-26 22:35:41 PST
Committed in <http://trac.webkit.org/r135819>.
Thiago Marcos P. Santos
Comment 4 2012-11-27 02:13:22 PST
This patch caused 276 failures on the EFL bots. http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/808
WebKit Review Bot
Comment 6 2012-11-27 03:26:28 PST
Re-opened since this is blocked by bug 103388
Csaba Osztrogonác
Comment 7 2012-11-27 03:34:03 PST
(In reply to comment #6) > Re-opened since this is blocked by bug 103388 Rollout landed in http://trac.webkit.org/changeset/135844
Csaba Osztrogonác
Comment 8 2012-11-27 03:35:21 PST
CC EFL and Qt guys, maybe you can help debugging the regression caused by this patch.
mitz
Comment 9 2012-11-27 13:52:02 PST
I am going to move the initialization of WebPage::m_mayStartMediaWhenInWindow so that it’s before the call to platformInitialize(), thinking that some platforms may call setIsInWindow() from there.
mitz
Comment 10 2012-11-27 13:54:04 PST
Fixed in <http://trac.webkit.org/r135915>.
Note You need to log in before you can comment on or make changes to this bug.