Summary: | freeV8NPObject: Fix crash when per context data's map doesn't have V8NPObject*. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | lazyboy | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, haraken, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
lazyboy
2012-11-26 21:09:28 PST
Created attachment 176162 [details]
Patch
Attachment 176162 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 176162 [details]
Patch
ok
Comment on attachment 176162 [details]
Patch
stylebot is right.
Created attachment 176276 [details]
Patch
Fixed Changelog to add bug id line, I missed it while running prepare-ChangeLog script
Comment on attachment 176276 [details] Patch Clearing flags on attachment: 176276 Committed r135874: <http://trac.webkit.org/changeset/135874> All reviewed patches have been landed. Closing bug. |