Bug 103356 - freeV8NPObject: Fix crash when per context data's map doesn't have V8NPObject*.
Summary: freeV8NPObject: Fix crash when per context data's map doesn't have V8NPObject*.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 21:09 PST by lazyboy
Modified: 2012-11-27 10:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.56 KB, patch)
2012-11-26 21:10 PST, lazyboy 		no flags Details | Formatted Diff | Diff
Patch (6.67 KB, patch)
2012-11-27 08:44 PST, lazyboy 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lazyboy 2012-11-26 21:09:28 PST 
freeV8NPObject: Fix crash when per context data's map doesn't have V8NPObject*.
Comment 1 lazyboy 2012-11-26 21:10:23 PST 
Created attachment 176162 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-26 21:14:23 PST 
Attachment 176162 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2012-11-26 21:14:50 PST 
Comment on attachment 176162 [details]
Patch

ok
Comment 4 Adam Barth 2012-11-26 21:15:15 PST 
Comment on attachment 176162 [details]
Patch

stylebot is right.
Comment 5 lazyboy 2012-11-27 08:44:24 PST 
Created attachment 176276 [details]
Patch

Fixed Changelog to add bug id line, I missed it while running prepare-ChangeLog script
Comment 6 WebKit Review Bot 2012-11-27 10:14:56 PST 
Comment on attachment 176276 [details]
Patch

Clearing flags on attachment: 176276

Committed r135874: <http://trac.webkit.org/changeset/135874>
Comment 7 WebKit Review Bot 2012-11-27 10:14:59 PST 
All reviewed patches have been landed.  Closing bug.