[CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Julien Chaffraix]

The specification changed these names since we implemented them.

It's probably too early to do it as the specification didn't stabilize enough.

[Martin Robinson]

Looks like the latest version of the spec [1] keeps this name, so perhaps it's safe to at least add an alias now.

1. http://www.w3.org/TR/css3-grid-layout/#track-sizing

[Martin Robinson]

Created attachment 200246 [details]
Patch

[Martin Robinson]

I've updated grid layout tests to reflect the new naming, but didn't update the ietestcenter tests. I figured it would be better to both keep the imported tests similar and to keep some coverage for the old name. I'm happy to change things around if this isn't the preferred approach.

[Sergio Villar Senin]

(In reply to comment #2)
> Created an attachment (id=200246) [details]
> Patch

Since we're not exposing this by default IMO it's OK just to rename them breaking compatibility with the old names instead of adding aliases.

Also consider changing all the references in the tests to the old names, there are several test descriptions that mention grid-rows and/or grid-columns. As far as I saw this involves changing the expected results of two tests as well

grid-element-change-columns-repaint.html
grid-element-change-rows-repaint.html

[Martin Robinson]

Created attachment 205201 [details]
Rename instead of alias and fix tests

[Martin Robinson]

Any reviewers willing to take this one?

[Tony Chang]

Comment on attachment 205201 [details]
Rename instead of alias and fix tests

View in context: https://bugs.webkit.org/attachment.cgi?id=205201&action=review

> Source/WebCore/ChangeLog:10
> +        Alias -webkit-grid-{rows|columns} to -webkit-grid-definition-{rows|columns}.
> +        The latest version of the spec has renamed these properties and an alias
> +        preserves backwards compatibility with older CSS.

This still talks about aliasing.

> Source/WebCore/ChangeLog:13
> +        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle the new aliases.

Here too.

> Source/WebCore/ChangeLog:20
> +        * css/CSSPropertyNames.in: Add support for the new aliases.
> +        * css/StyleResolver.cpp:
> +        (WebCore::StyleResolver::applyProperty): Handle the new aliases.

Also here.

[Martin Robinson]

Committed r152479: <http://trac.webkit.org/changeset/152479>