Bug 103312

Summary:

[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Layout and Rendering

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, dino, donggwan.kim, esprehn+autocc, glenn, gyuyoung.kim, kling, koivisto, macpherson, menard, ojan, svillar, syoichi, tony, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

60731

Attachments:

Description	Flags
Patch	kling: review+

Description Julien Chaffraix 2012-11-26 15:59:07 PST

The specification allows a grid definition to be repeated by using the repeat() function:

<track-list>    => [ [ <string> ]* <track-group> [ <string> ]* ]+ | none
<track-group>   => <track-minmax> | [ repeat( <positive-integer> , [ [ <string> ]* <track-minmax> [ <string> ]* ]+ ) ]

Comment 1 Sergio Villar Senin 2013-11-11 09:13:54 PST

Created attachment 216577 [details]
Patch

Comment 2 Sergio Villar Senin 2013-11-13 01:25:19 PST

Adding reviewers

Comment 3 Andreas Kling 2013-11-26 10:00:56 PST

Comment on attachment 216577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216577&action=review

r=me

> Source/WebCore/css/CSSParser.cpp:5048
> +            values->append(primitiveValue);

values->append(primitiveValue.release());

> Source/WebCore/css/CSSParser.cpp:5086
> +        repeatedValues->append(trackSize);

repeatedValues->append(trackSize.release());

Comment 4 Sergio Villar Senin 2013-11-27 00:28:47 PST

Committed r159808: <http://trac.webkit.org/changeset/159808>