Bug 103312

Summary: [CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dino, donggwan.kim, esprehn+autocc, glenn, gyuyoung.kim, kling, koivisto, macpherson, menard, ojan, svillar, syoichi, tony, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch kling: review+

Julien Chaffraix
Reported 2012-11-26 15:59:07 PST
The specification allows a grid definition to be repeated by using the repeat() function: <track-list> => [ [ <string> ]* <track-group> [ <string> ]* ]+ | none <track-group> => <track-minmax> | [ repeat( <positive-integer> , [ [ <string> ]* <track-minmax> [ <string> ]* ]+ ) ]
Attachments
Patch (17.81 KB, patch)
2013-11-11 09:13 PST, Sergio Villar Senin 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2013-11-11 09:13:54 PST
Created attachment 216577 [details] Patch
Sergio Villar Senin
Comment 2 2013-11-13 01:25:19 PST
Adding reviewers
Andreas Kling
Comment 3 2013-11-26 10:00:56 PST
Comment on attachment 216577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216577&action=review r=me > Source/WebCore/css/CSSParser.cpp:5048 > + values->append(primitiveValue); values->append(primitiveValue.release()); > Source/WebCore/css/CSSParser.cpp:5086 > + repeatedValues->append(trackSize); repeatedValues->append(trackSize.release());
Sergio Villar Senin
Comment 4 2013-11-27 00:28:47 PST
Committed r159808: <http://trac.webkit.org/changeset/159808>
Note You need to log in before you can comment on or make changes to this bug.