Bug 103291

Summary: PDFPlugin: Page scale factor should affect subframe PDFs
Product: WebKit Reporter: Tim Horton <thorton>
Component: PDFAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, mitz, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch darin: review+

Tim Horton
Reported 2012-11-26 13:55:58 PST
For subframe PDFs, hand PDFKit the pageScaleFactor for the parent page so it can scale its drawing appropriately. <rdar://problem/12555249>
Attachments
patch (5.44 KB, patch)
2012-11-26 14:46 PST, Tim Horton 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2012-11-26 14:46:59 PST
Created attachment 176078 [details] patch
Darin Adler
Comment 2 2012-11-27 09:56:15 PST
Comment on attachment 176078 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=176078&action=review > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:323 > + float newScaleFactor = controller()->contentsScaleFactor(); Is float the correct type here?
Tim Horton
Comment 3 2012-11-27 13:49:13 PST
(In reply to comment #2) > (From update of attachment 176078 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=176078&action=review > > > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:323 > > + float newScaleFactor = controller()->contentsScaleFactor(); > > Is float the correct type here? Nope. Thanks, Darin!
Tim Horton
Comment 4 2012-11-27 14:46:48 PST
http://trac.webkit.org/changeset/135925
Note You need to log in before you can comment on or make changes to this bug.