Bug 103273

Summary: [Cairo] Surface should not be destroyed before its usage
Product: WebKit Reporter: Rafael Brandao <rafael.lobo>
Component: New BugsAssignee: Rafael Brandao <rafael.lobo>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, kenneth, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Rafael Brandao 2012-11-26 10:29:03 PST 
[Cairo] Surface should not be destroyed before its usage
Comment 1 Rafael Brandao 2012-11-26 10:31:18 PST 
Created attachment 176029 [details]
Patch
Comment 2 Brent Fulgham 2012-11-26 10:53:29 PST 
Comment on attachment 176029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176029&action=review

Great catch. r=me.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:-363
> -    cairo_surface_destroy(surface);

Wow!  I'm surprised this ever worked.
Comment 3 Rafael Brandao 2012-11-26 10:54:38 PST 
Comment on attachment 176029 [details]
Patch

Me too. :-)
Comment 4 WebKit Review Bot 2012-11-26 11:12:48 PST 
Comment on attachment 176029 [details]
Patch

Clearing flags on attachment: 176029

Committed r135742: <http://trac.webkit.org/changeset/135742>
Comment 5 WebKit Review Bot 2012-11-26 11:12:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Kenneth Rohde Christiansen 2012-11-26 15:17:18 PST 
Comment on attachment 176029 [details]
Patch

Nice
Comment 7 Kenneth Rohde Christiansen 2012-11-26 15:17:51 PST 
Btw, did this solve any reproducible bugs?
Comment 8 Rafael Brandao 2012-11-26 15:21:24 PST 
(In reply to comment #7)
> Btw, did this solve any reproducible bugs?

I wish, but I couldn't observe anything. I'm focusing on the scale < 1.0 bug right now and stumbled right into this.