Bug 103264

Summary: INVALID_STATE_ERR error upon calling .addCue() for an already-in-use cue
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dino, eric.carlson, feature-media-reviews, gyuyoung.kim, ojan, rakuco, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://w3c-test.org/html/tests/submission/Opera/media/interfaces/TextTrack/addCue.html
Attachments:
Description Flags
Patch
none
Patch
none
Patch eric.carlson: review+, webkit.review.bot: commit-queue-

Antoine Quint
Reported 2012-11-26 08:43:21 PST
The first test of the Opera-submitted test at http://w3c-test.org/html/tests/submission/Opera/media/interfaces/TextTrack/addCue.html fails because we try adding a cue to a TextTrack and that cue was already added to a previous track. The spec says that the cue must first be removed from the previous track before being added to the new track (http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#dom-texttrack-addcue). However, when we try to do that we get an INVALID_STATE_ERR error thrown, which is odd because the .addCue() method does not seem to throw exceptions.
Attachments
Patch (9.69 KB, patch)
2012-12-04 02:28 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (9.85 KB, patch)
2012-12-04 06:32 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (12.08 KB, patch)
2012-12-04 08:03 PST, Antoine Quint 		eric.carlson: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2012-11-27 01:54:07 PST
<rdar://problem/12756208>
Antoine Quint
Comment 2 2012-12-04 02:28:58 PST
Created attachment 177456 [details] Patch
Antoine Quint
Comment 3 2012-12-04 02:29:47 PST
*** Bug 103265 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 4 2012-12-04 05:34:08 PST
Comment on attachment 177456 [details] Patch Rejecting attachment 177456 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: it line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit + 9347176...16632b5 HEAD -> origin/HEAD (forced update) error: Ref refs/remotes/origin/master is at 16632b5a2ddd0ea34bb124d8f915fd9521310601 but expected 93471767af9bca55738741a12786ee27fce6e006 ! 9347176...16632b5 master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15133401
Antoine Quint
Comment 5 2012-12-04 06:32:21 PST
Created attachment 177473 [details] Patch
Antoine Quint
Comment 6 2012-12-04 08:03:34 PST
Created attachment 177481 [details] Patch
WebKit Review Bot
Comment 7 2012-12-04 08:31:55 PST
Comment on attachment 177481 [details] Patch Rejecting attachment 177481 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ripts/update-webkit line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit 700060b..82ee932 HEAD -> origin/HEAD error: Ref refs/remotes/origin/master is at 82ee9326539c61f4c4cb100778394db7ec65bec2 but expected 700060b2bfffbae7da2848a0b266fb18f70e8b39 ! 700060b..82ee932 master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15121796
Dean Jackson
Comment 8 2012-12-04 10:49:05 PST
Committed r136528: <http://trac.webkit.org/changeset/136528>
Note You need to log in before you can comment on or make changes to this bug.