Bug 103240

Summary: Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, caseq, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Eugene Klyuchnikov 2012-11-26 04:18:58 PST
Cleanup: remove redundant dependency.
Comment 1 Eugene Klyuchnikov 2012-11-26 04:24:26 PST
Created attachment 175968 [details]
Patch
Comment 2 Yury Semikhatsky 2012-11-26 04:30:30 PST
Comment on attachment 175968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review

> LayoutTests/inspector/profiler/heap-snapshot-test.js:746
> +InspectorTest._currentView = function()

I'd give it a more specific name, probably _currentProfileView ?
Comment 3 Eugene Klyuchnikov 2012-11-26 04:43:58 PST
Comment on attachment 175968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review

>> LayoutTests/inspector/profiler/heap-snapshot-test.js:746
>> +InspectorTest._currentView = function()
> 
> I'd give it a more specific name, probably _currentProfileView ?

Done.
Comment 4 Eugene Klyuchnikov 2012-11-26 04:44:52 PST
Created attachment 175971 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-26 05:38:07 PST
Comment on attachment 175971 [details]
Patch

Clearing flags on attachment: 175971

Committed r135708: <http://trac.webkit.org/changeset/135708>
Comment 6 WebKit Review Bot 2012-11-26 05:38:10 PST
All reviewed patches have been landed.  Closing bug.