Summary: | Web Inspector: HeapProfiler: remove snapshotView reference from data-grids. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eugene Klyuchnikov <eustas> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Eugene Klyuchnikov <eustas> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, caseq, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Eugene Klyuchnikov
2012-11-26 04:18:58 PST
Created attachment 175968 [details]
Patch
Comment on attachment 175968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review > LayoutTests/inspector/profiler/heap-snapshot-test.js:746 > +InspectorTest._currentView = function() I'd give it a more specific name, probably _currentProfileView ? Comment on attachment 175968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review >> LayoutTests/inspector/profiler/heap-snapshot-test.js:746 >> +InspectorTest._currentView = function() > > I'd give it a more specific name, probably _currentProfileView ? Done. Created attachment 175971 [details]
Patch
Comment on attachment 175971 [details] Patch Clearing flags on attachment: 175971 Committed r135708: <http://trac.webkit.org/changeset/135708> All reviewed patches have been landed. Closing bug. |