Bug 103240

Summary:

Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.

Product:

WebKit

Reporter:

Eugene Klyuchnikov <eustas>

Component:

Web Inspector (Deprecated)

Assignee:

Eugene Klyuchnikov <eustas>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, caseq, eustas, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Eugene Klyuchnikov

Reported 2012-11-26 04:18:58 PST

Cleanup: remove redundant dependency.

Attachments
Patch (8.03 KB, patch) 2012-11-26 04:24 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
Patch (8.08 KB, patch) 2012-11-26 04:44 PST, Eugene Klyuchnikov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eugene Klyuchnikov

Comment 1 2012-11-26 04:24:26 PST

Yury Semikhatsky

Comment 2 2012-11-26 04:30:30 PST

Comment on attachment 175968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review > LayoutTests/inspector/profiler/heap-snapshot-test.js:746 > +InspectorTest._currentView = function() I'd give it a more specific name, probably _currentProfileView ?

Eugene Klyuchnikov

Comment 3 2012-11-26 04:43:58 PST

Comment on attachment 175968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review >> LayoutTests/inspector/profiler/heap-snapshot-test.js:746 >> +InspectorTest._currentView = function() > > I'd give it a more specific name, probably _currentProfileView ? Done.

Eugene Klyuchnikov

Comment 4 2012-11-26 04:44:52 PST

WebKit Review Bot

Comment 5 2012-11-26 05:38:07 PST

WebKit Review Bot

Comment 6 2012-11-26 05:38:10 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.