Bug 103240 - Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
Summary: Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eugene Klyuchnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 04:18 PST by Eugene Klyuchnikov
Modified: 2012-11-26 05:38 PST (History)
11 users (show)

See Also:


Attachments
Patch (8.03 KB, patch)
2012-11-26 04:24 PST, Eugene Klyuchnikov
no flags Details | Formatted Diff | Diff
Patch (8.08 KB, patch)
2012-11-26 04:44 PST, Eugene Klyuchnikov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Klyuchnikov 2012-11-26 04:18:58 PST
Cleanup: remove redundant dependency.
Comment 1 Eugene Klyuchnikov 2012-11-26 04:24:26 PST
Created attachment 175968 [details]
Patch
Comment 2 Yury Semikhatsky 2012-11-26 04:30:30 PST
Comment on attachment 175968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review

> LayoutTests/inspector/profiler/heap-snapshot-test.js:746
> +InspectorTest._currentView = function()

I'd give it a more specific name, probably _currentProfileView ?
Comment 3 Eugene Klyuchnikov 2012-11-26 04:43:58 PST
Comment on attachment 175968 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review

>> LayoutTests/inspector/profiler/heap-snapshot-test.js:746
>> +InspectorTest._currentView = function()
> 
> I'd give it a more specific name, probably _currentProfileView ?

Done.
Comment 4 Eugene Klyuchnikov 2012-11-26 04:44:52 PST
Created attachment 175971 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-26 05:38:07 PST
Comment on attachment 175971 [details]
Patch

Clearing flags on attachment: 175971

Committed r135708: <http://trac.webkit.org/changeset/135708>
Comment 6 WebKit Review Bot 2012-11-26 05:38:10 PST
All reviewed patches have been landed.  Closing bug.