RESOLVED FIXED 103240
Web Inspector: HeapProfiler: remove snapshotView reference from data-grids. 
https://bugs.webkit.org/show_bug.cgi?id=103240
Summary Web Inspector: HeapProfiler: remove snapshotView reference from data-grids.
Eugene Klyuchnikov
Reported 2012-11-26 04:18:58 PST
Cleanup: remove redundant dependency.
Attachments
Patch (8.03 KB, patch)
2012-11-26 04:24 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Patch (8.08 KB, patch)
2012-11-26 04:44 PST, Eugene Klyuchnikov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2012-11-26 04:24:26 PST
Created attachment 175968 [details] Patch
Yury Semikhatsky
Comment 2 2012-11-26 04:30:30 PST
Comment on attachment 175968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review > LayoutTests/inspector/profiler/heap-snapshot-test.js:746 > +InspectorTest._currentView = function() I'd give it a more specific name, probably _currentProfileView ?
Eugene Klyuchnikov
Comment 3 2012-11-26 04:43:58 PST
Comment on attachment 175968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175968&action=review >> LayoutTests/inspector/profiler/heap-snapshot-test.js:746 >> +InspectorTest._currentView = function() > > I'd give it a more specific name, probably _currentProfileView ? Done.
Eugene Klyuchnikov
Comment 4 2012-11-26 04:44:52 PST
Created attachment 175971 [details] Patch
WebKit Review Bot
Comment 5 2012-11-26 05:38:07 PST
Comment on attachment 175971 [details] Patch Clearing flags on attachment: 175971 Committed r135708: <http://trac.webkit.org/changeset/135708>
WebKit Review Bot
Comment 6 2012-11-26 05:38:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.