Summary: | Web Inspector: unify agents handling in Page and Worker inspector controllers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, keishi, loislo, ossy, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Yury Semikhatsky
2012-11-26 03:52:32 PST
Created attachment 175961 [details]
Patch
Comment on attachment 175961 [details] Patch Clearing flags on attachment: 175961 Committed r135713: <http://trac.webkit.org/changeset/135713> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > (From update of attachment 175961 [details]) > Clearing flags on attachment: 175961 > > Committed r135713: <http://trac.webkit.org/changeset/135713> It broke the build on !ENABLE(INSPECTOR) platforms. (for example the Qt's minimal bot) See http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/65940/steps/compile-webkit/logs/stdio for details. Comment on attachment 175961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175961&action=review > Source/WebCore/inspector/InspectorBaseAgent.h:68 > +class InspectorAgentRegistry { Nit: I'd call it InspectorAgents or InspectorAgentCollection. It is not yet a registry. (In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 175961 [details] [details]) > > Clearing flags on attachment: 175961 > > > > Committed r135713: <http://trac.webkit.org/changeset/135713> > > It broke the build on !ENABLE(INSPECTOR) platforms. (for example the Qt's minimal bot) See http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/65940/steps/compile-webkit/logs/stdio for details. Fix landed http://trac.webkit.org/changeset/135721, sorry about that. Not problem, thanks for the quick fix. |