Bug 103238 - Web Inspector: unify agents handling in Page and Worker inspector controllers
Summary: Web Inspector: unify agents handling in Page and Worker inspector controllers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-26 03:52 PST by Yury Semikhatsky
Modified: 2012-11-26 07:45 PST (History)
10 users (show)

See Also:


Attachments
Patch (13.83 KB, patch)
2012-11-26 03:56 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-11-26 03:52:32 PST
The logic is the same in both cases, we should encapsulate it in a single class.
Comment 1 Yury Semikhatsky 2012-11-26 03:56:40 PST
Created attachment 175961 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-26 06:07:46 PST
Comment on attachment 175961 [details]
Patch

Clearing flags on attachment: 175961

Committed r135713: <http://trac.webkit.org/changeset/135713>
Comment 3 WebKit Review Bot 2012-11-26 06:07:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2012-11-26 06:26:39 PST
(In reply to comment #2)
> (From update of attachment 175961 [details])
> Clearing flags on attachment: 175961
> 
> Committed r135713: <http://trac.webkit.org/changeset/135713>

It broke the build on !ENABLE(INSPECTOR) platforms. (for example the Qt's minimal bot) See http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/65940/steps/compile-webkit/logs/stdio for details.
Comment 5 Pavel Feldman 2012-11-26 06:32:37 PST
Comment on attachment 175961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175961&action=review

> Source/WebCore/inspector/InspectorBaseAgent.h:68
> +class InspectorAgentRegistry {

Nit: I'd call it InspectorAgents or InspectorAgentCollection. It is not yet a registry.
Comment 6 Yury Semikhatsky 2012-11-26 07:29:14 PST
(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 175961 [details] [details])
> > Clearing flags on attachment: 175961
> > 
> > Committed r135713: <http://trac.webkit.org/changeset/135713>
> 
> It broke the build on !ENABLE(INSPECTOR) platforms. (for example the Qt's minimal bot) See http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/65940/steps/compile-webkit/logs/stdio for details.

Fix landed http://trac.webkit.org/changeset/135721, sorry about that.
Comment 7 Csaba Osztrogonác 2012-11-26 07:45:26 PST
Not problem, thanks for the quick fix.