RESOLVED FIXED 103238
Web Inspector: unify agents handling in Page and Worker inspector controllers 
https://bugs.webkit.org/show_bug.cgi?id=103238
Summary Web Inspector: unify agents handling in Page and Worker inspector controllers
Yury Semikhatsky
Reported 2012-11-26 03:52:32 PST
The logic is the same in both cases, we should encapsulate it in a single class.
Attachments
Patch (13.83 KB, patch)
2012-11-26 03:56 PST, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-11-26 03:56:40 PST
Created attachment 175961 [details] Patch
WebKit Review Bot
Comment 2 2012-11-26 06:07:46 PST
Comment on attachment 175961 [details] Patch Clearing flags on attachment: 175961 Committed r135713: <http://trac.webkit.org/changeset/135713>
WebKit Review Bot
Comment 3 2012-11-26 06:07:49 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2012-11-26 06:26:39 PST
(In reply to comment #2) > (From update of attachment 175961 [details]) > Clearing flags on attachment: 175961 > > Committed r135713: <http://trac.webkit.org/changeset/135713> It broke the build on !ENABLE(INSPECTOR) platforms. (for example the Qt's minimal bot) See http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/65940/steps/compile-webkit/logs/stdio for details.
Pavel Feldman
Comment 5 2012-11-26 06:32:37 PST
Comment on attachment 175961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175961&action=review > Source/WebCore/inspector/InspectorBaseAgent.h:68 > +class InspectorAgentRegistry { Nit: I'd call it InspectorAgents or InspectorAgentCollection. It is not yet a registry.
Yury Semikhatsky
Comment 6 2012-11-26 07:29:14 PST
(In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 175961 [details] [details]) > > Clearing flags on attachment: 175961 > > > > Committed r135713: <http://trac.webkit.org/changeset/135713> > > It broke the build on !ENABLE(INSPECTOR) platforms. (for example the Qt's minimal bot) See http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/65940/steps/compile-webkit/logs/stdio for details. Fix landed http://trac.webkit.org/changeset/135721, sorry about that.
Csaba Osztrogonác
Comment 7 2012-11-26 07:45:26 PST
Not problem, thanks for the quick fix.
Note You need to log in before you can comment on or make changes to this bug.