Bug 103190

Summary: [BlackBerry] Find-on-page keeps stale pointer
Product: WebKit Reporter: Andy Chen <andchen>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andy Chen
Reported 2012-11-24 15:53:00 PST
It keeps stale pointer of frame. If the frame is unloaded, searching on that frame would cause segmentation fault.
Attachments
Patch (2.20 KB, patch)
2012-11-24 17:12 PST, Andy Chen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Chen
Comment 1 2012-11-24 17:12:46 PST
Created attachment 175869 [details] Patch
Rob Buis
Comment 2 2012-11-24 17:19:21 PST
Comment on attachment 175869 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175869&action=review LGTM. > Source/WebKit/blackberry/WebKitSupport/InPageSearchManager.cpp:251 > + for (size_t i = 0; i < m_deferredScopingWork.size(); i++) { pre-increment is more efficient.
WebKit Review Bot
Comment 3 2012-11-24 19:03:36 PST
Comment on attachment 175869 [details] Patch Rejecting attachment 175869 [details] from commit-queue. New failing tests: svg/W3C-SVG-1.1/animate-elem-78-t.svg Full output: http://queues.webkit.org/results/14984154
WebKit Review Bot
Comment 4 2012-11-24 20:14:14 PST
Comment on attachment 175869 [details] Patch Clearing flags on attachment: 175869 Committed r135664: <http://trac.webkit.org/changeset/135664>
WebKit Review Bot
Comment 5 2012-11-24 20:14:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.