Bug 103189

Summary: [EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103186    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2012-11-24 14:45:48 PST 
ThemePartCacheEntry::reuse() does not currently check if the size and type changed before doing processing. This may lead to useless processing in case one of those (size or type) did not change.
Comment 1 Chris Dumez 2012-11-24 14:55:50 PST 
Created attachment 175866 [details]
Patch
Comment 2 Chris Dumez 2012-11-24 14:59:10 PST 
Created attachment 175867 [details]
Patch
Comment 3 Mikhail Pozdnyakov 2012-11-24 15:08:06 PST 
Comment on attachment 175867 [details]
Patch

LGTM
Comment 4 WebKit Review Bot 2012-11-24 20:39:52 PST 
Comment on attachment 175867 [details]
Patch

Rejecting attachment 175867 [details] from commit-queue.

New failing tests:
svg/W3C-SVG-1.1/animate-elem-78-t.svg
Full output: http://queues.webkit.org/results/14982191
Comment 5 Chris Dumez 2012-11-25 00:48:38 PST 
Comment on attachment 175867 [details]
Patch

This patch cannot affect chromium so it must be a false warning. Requesting cq? again.
Comment 6 WebKit Review Bot 2012-11-25 11:19:53 PST 
Comment on attachment 175867 [details]
Patch

Clearing flags on attachment: 175867

Committed r135673: <http://trac.webkit.org/changeset/135673>
Comment 7 WebKit Review Bot 2012-11-25 11:19:58 PST 
All reviewed patches have been landed.  Closing bug.