Bug 103189

Summary: [EFL] Refactor RenderThemeEfl::ThemePartCacheEntry::reuse()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103186    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2012-11-24 14:45:48 PST
ThemePartCacheEntry::reuse() does not currently check if the size and type changed before doing processing. This may lead to useless processing in case one of those (size or type) did not change.
Attachments
Patch (2.45 KB, patch)
2012-11-24 14:55 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.23 KB, patch)
2012-11-24 14:59 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-11-24 14:55:50 PST
Created attachment 175866 [details] Patch
Chris Dumez
Comment 2 2012-11-24 14:59:10 PST
Created attachment 175867 [details] Patch
Mikhail Pozdnyakov
Comment 3 2012-11-24 15:08:06 PST
Comment on attachment 175867 [details] Patch LGTM
WebKit Review Bot
Comment 4 2012-11-24 20:39:52 PST
Comment on attachment 175867 [details] Patch Rejecting attachment 175867 [details] from commit-queue. New failing tests: svg/W3C-SVG-1.1/animate-elem-78-t.svg Full output: http://queues.webkit.org/results/14982191
Chris Dumez
Comment 5 2012-11-25 00:48:38 PST
Comment on attachment 175867 [details] Patch This patch cannot affect chromium so it must be a false warning. Requesting cq? again.
WebKit Review Bot
Comment 6 2012-11-25 11:19:53 PST
Comment on attachment 175867 [details] Patch Clearing flags on attachment: 175867 Committed r135673: <http://trac.webkit.org/changeset/135673>
WebKit Review Bot
Comment 7 2012-11-25 11:19:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.