Bug 103187

Summary: [EFL][WK2] Stop the mess with DECLARE_EWK_VIEW_CALLBACK arg type definition
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Mikhail Pozdnyakov
Reported 2012-11-24 13:32:40 PST
Currently the client has to pass "char" in DECLARE_EWK_VIEW_CALLBACK if s/he wants to have string (const char* actually) as callback parameter, has to pass 'Ewk_Error' if wants to have 'Ewk_Error*' but at the same time passes just 'void' if wants to have 'void' -- this is real mess which I cannot stand any more! Patch is coming.
Attachments
patch (9.58 KB, patch)
2012-11-24 13:38 PST, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-11-24 13:38:36 PST
Created attachment 175865 [details] patch
Chris Dumez
Comment 2 2012-11-24 14:25:14 PST
Comment on attachment 175865 [details] patch LGTM. Much better indeed.
WebKit Review Bot
Comment 3 2012-11-24 18:18:53 PST
Comment on attachment 175865 [details] patch Clearing flags on attachment: 175865 Committed r135660: <http://trac.webkit.org/changeset/135660>
WebKit Review Bot
Comment 4 2012-11-24 18:18:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.