Bug 103169

Summary: REGRESSION(r135575): It made all tests assert (Requested by Ossy on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, cmarcelo, hausmann, menard, ossy, pierre.rossi, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
ROLLOUT of r135575
none
Patch
none
Patch none

Description WebKit Review Bot 2012-11-23 22:11:13 PST 
http://trac.webkit.org/changeset/135575 broke the build:
It made all tests assert (Requested by Ossy on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-11-23 22:11:49 PST 
Created attachment 175850 [details]
ROLLOUT of r135575

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Csaba Osztrogonác 2012-11-23 22:14:05 PST 
Comment on attachment 175850 [details]
ROLLOUT of r135575

Clearing flags on attachment: 175850

Committed r135642: <http://trac.webkit.org/changeset/135642>
Comment 3 Csaba Osztrogonác 2012-11-23 22:14:31 PST 
See http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/26447 for details.
Comment 4 Pierre Rossi 2012-11-25 17:18:53 PST 
Created attachment 175902 [details]
Patch

forgot to grep in Tools/ apparently...
Comment 5 Early Warning System Bot 2012-11-25 17:24:31 PST 
Comment on attachment 175902 [details]
Patch

Attachment 175902 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14980538
Comment 6 Early Warning System Bot 2012-11-25 17:24:56 PST 
Comment on attachment 175902 [details]
Patch

Attachment 175902 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14988396
Comment 7 Pierre Rossi 2012-11-26 02:30:07 PST 
Created attachment 175947 [details]
Patch
Comment 8 Simon Hausmann 2012-11-26 03:08:09 PST 
Landed manually because it also fixes the widget-less build probably

Committed r135701: <http://trac.webkit.org/changeset/135701>
Comment 9 Andras Becsi 2012-11-26 05:14:27 PST 
Comment on attachment 175947 [details]
Patch

Clearing flags, since the patch has already been landed manually in http://trac.webkit.org/changeset/135701