RESOLVED FIXED 103169
REGRESSION(r135575): It made all tests assert (Requested by Ossy on #webkit). 
https://bugs.webkit.org/show_bug.cgi?id=103169
Summary REGRESSION(r135575): It made all tests assert (Requested by Ossy on #webkit).
WebKit Review Bot
Reported 2012-11-23 22:11:13 PST
http://trac.webkit.org/changeset/135575 broke the build: It made all tests assert (Requested by Ossy on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r135575 (3.67 KB, patch)
2012-11-23 22:11 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
Patch (5.78 KB, patch)
2012-11-25 17:18 PST, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Patch (6.86 KB, patch)
2012-11-26 02:30 PST, Pierre Rossi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-11-23 22:11:49 PST
Created attachment 175850 [details] ROLLOUT of r135575 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Csaba Osztrogonác
Comment 2 2012-11-23 22:14:05 PST
Comment on attachment 175850 [details] ROLLOUT of r135575 Clearing flags on attachment: 175850 Committed r135642: <http://trac.webkit.org/changeset/135642>
Csaba Osztrogonác
Comment 3 2012-11-23 22:14:31 PST
See http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/26447 for details.
Pierre Rossi
Comment 4 2012-11-25 17:18:53 PST
Created attachment 175902 [details] Patch forgot to grep in Tools/ apparently...
Early Warning System Bot
Comment 5 2012-11-25 17:24:31 PST
Comment on attachment 175902 [details] Patch Attachment 175902 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14980538
Early Warning System Bot
Comment 6 2012-11-25 17:24:56 PST
Comment on attachment 175902 [details] Patch Attachment 175902 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14988396
Pierre Rossi
Comment 7 2012-11-26 02:30:07 PST
Created attachment 175947 [details] Patch
Simon Hausmann
Comment 8 2012-11-26 03:08:09 PST
Landed manually because it also fixes the widget-less build probably Committed r135701: <http://trac.webkit.org/changeset/135701>
Andras Becsi
Comment 9 2012-11-26 05:14:27 PST
Comment on attachment 175947 [details] Patch Clearing flags, since the patch has already been landed manually in http://trac.webkit.org/changeset/135701
Note You need to log in before you can comment on or make changes to this bug.