Bug 103143

Summary: GraphicsSurface should only store its size in a single place.
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: New BugsAssignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, kenneth, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kenneth: review+

Description Zeno Albisser 2012-11-23 07:46:12 PST 
GraphicsSurface should only store its size in a single place.
Comment 1 Zeno Albisser 2012-11-23 07:55:00 PST 
Created attachment 175810 [details]
Patch
Comment 2 Zeno Albisser 2012-11-24 06:44:58 PST 
Sorry Kenneth, i messed up here.
There is something missing in this patch.

I need to add a ctor for GraphicsSurfacePrivate that takes a winId as an argument as well.
I'll upload an updated patch.
Comment 3 Kenneth Rohde Christiansen 2012-11-24 06:53:47 PST 
OK fine!
Comment 4 Zeno Albisser 2012-11-24 07:36:07 PST 
Created attachment 175857 [details]
Patch
Comment 5 Kenneth Rohde Christiansen 2012-11-24 07:52:12 PST 
Comment on attachment 175857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175857&action=review

> Source/WebCore/ChangeLog:25
> +            Retreive the size from GraphicsSurfacePrivate where necessary.

retrieve*

> Source/WebCore/ChangeLog:39
> +            Retreive the size from GraphicsSurfacePrivate where necessary.

retrieve*
Comment 6 Zeno Albisser 2012-11-26 04:33:08 PST 
Committed r135706: <http://trac.webkit.org/changeset/135706>