Bug 10314

Summary: WebUnarchivingState archivedResourceForURL: doesn't work
Product: WebKit Reporter: Graham Dennis <Graham.Dennis>
Component: New BugsAssignee: Graham Dennis <Graham.Dennis>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch darin: review+

Graham Dennis
Reported 2006-08-08 19:10:57 PDT
This method tries to get the object from the archivedResources dictionary with a key of (NSURL *)URL, however, objects are put into that dictionary with (NSString *)[URL _web_originalDataAsString]. This prevents the data for applewebdata:// URL's (e.g. for pasted images) to be fetched correctly for WebCore's cache. Patch forthcoming.
Attachments
patch (1.29 KB, patch)
2006-08-08 19:20 PDT, Graham Dennis 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Graham Dennis
Comment 1 2006-08-08 19:20:51 PDT
Created attachment 9951 [details] patch Patch.
Darin Adler
Comment 2 2006-08-10 16:57:28 PDT
Comment on attachment 9951 [details] patch Clearly correct. Great change. Can we make a test for this?
Graham Dennis
Comment 3 2006-08-10 17:03:53 PDT
I forgot to mention the lack of a test when I submitted the patch. I'm not sure how to create a testcase for this... hints?
Darin Adler
Comment 4 2006-08-15 08:06:48 PDT
(In reply to comment #3) > I forgot to mention the lack of a test when I submitted the patch. I'm not sure > how to create a testcase for this... hints? Using the new code that allows you to make Objective-C calls from JavaScript DumpRenderTree tests I imagine you could call this method. Beyond that, I'm not sure of the details.
Darin Adler
Comment 5 2006-08-15 08:08:00 PDT
Committed revision 15878.
Note You need to log in before you can comment on or make changes to this bug.