Bug 103125 – tst_qwebpage fails after QMimeDatabase patch

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Allan Sandfeld Jensen]

The API test tst_qwebpage relies on a static translation of extensions to mimetypes and fails after QtWebKit has been updated to use the QMimeDatabase, because one of the types has a different translation in QMimeDatabase.

[Allan Sandfeld Jensen]

Created attachment 175777 [details]
Patch

[WebKit Review Bot]

Attachment 175777 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1
Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2992:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Hausmann]

Comment on attachment 175777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175777&action=review

>> Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2992
>> +   contentTypes << "application/x-mimearchive";
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

This is indeed a three character indent instead of four. Please fix before landing :)

[Allan Sandfeld Jensen]

Committed r135602: <http://trac.webkit.org/changeset/135602>