Bug 103124

Summary: Remove references to non-chromium entries from WebCore.gypi (part 2)
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: WebCore Misc.Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, pfeldman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103126    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Yury Semikhatsky 2012-11-23 04:14:01 PST
There are many entries for gtk, cocoa and other platforms that are later filtered out but they cause chromium compilation errors on changes in those platforms like http://trac.webkit.org/changeset/135255. There is no need to reference these files from WebCore.gypi
Comment 1 Yury Semikhatsky 2012-11-23 04:16:05 PST
Created attachment 175775 [details]
Patch
Comment 2 Pavel Feldman 2012-11-23 04:20:13 PST
Comment on attachment 175775 [details]
Patch

"I regret nothing"?
Comment 3 WebKit Review Bot 2012-11-23 04:38:51 PST
Comment on attachment 175775 [details]
Patch

Clearing flags on attachment: 175775

Committed r135592: <http://trac.webkit.org/changeset/135592>
Comment 4 WebKit Review Bot 2012-11-23 04:38:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2012-11-23 04:55:36 PST
Re-opened since this is blocked by bug 103126
Comment 6 Alexey Proskuryakov 2012-11-23 23:43:50 PST
> There is no need to reference these files from WebCore.gypi

I've been told that there was a need - Chromium developers wanted these files in generated Xcode and MSVC project files for reference. I only have third hand information, and don't know who exactly wanted this.
Comment 7 Yury Semikhatsky 2012-11-26 00:04:35 PST
(In reply to comment #6)
> > There is no need to reference these files from WebCore.gypi
> 
> I've been told that there was a need - Chromium developers wanted these files in generated Xcode and MSVC project files for reference. I only have third hand information, and don't know who exactly wanted this.

Yeah, as build bots showed Chromium depends on some of the win and mac files. But the rest still can be removed.
Comment 8 Alexey Proskuryakov 2012-11-26 08:40:34 PST
This is not what I said - it was not about not breaking the build, but about having the files in project for humans to easily access them.

I don't have any opinion on whether it's desirable or not.
Comment 9 Adam Barth 2012-11-26 09:36:35 PST
> I don't have any opinion on whether it's desirable or not.

IMHO, the cost of having the Windows build mysteriously break when a non-Chromium file is renamed is greater than any benefit folks get by having these files listed in the IDE.
Comment 10 Yury Semikhatsky 2013-03-26 06:12:30 PDT
Created attachment 195073 [details]
Patch
Comment 11 Yury Semikhatsky 2013-03-26 06:20:11 PDT
Committed r146874: <http://trac.webkit.org/changeset/146874>