Bug 103124

Summary:

Remove references to non-chromium entries from WebCore.gypi (part 2)

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

WebCore Misc.

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, pfeldman, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

103126

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review+

Yury Semikhatsky

Reported 2012-11-23 04:14:01 PST

There are many entries for gtk, cocoa and other platforms that are later filtered out but they cause chromium compilation errors on changes in those platforms like http://trac.webkit.org/changeset/135255. There is no need to reference these files from WebCore.gypi

Attachments
Patch (32.59 KB, patch) 2012-11-23 04:16 PST, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Patch (27.16 KB, patch) 2013-03-26 06:12 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2012-11-23 04:16:05 PST

Created attachment 175775 [details] Patch

Pavel Feldman

Comment 2 2012-11-23 04:20:13 PST

Comment on attachment 175775 [details] Patch "I regret nothing"?

WebKit Review Bot

Comment 3 2012-11-23 04:38:51 PST

Comment on attachment 175775 [details] Patch Clearing flags on attachment: 175775 Committed r135592: <http://trac.webkit.org/changeset/135592>

WebKit Review Bot

Comment 4 2012-11-23 04:38:54 PST

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 5 2012-11-23 04:55:36 PST

Re-opened since this is blocked by bug 103126

Alexey Proskuryakov

Comment 6 2012-11-23 23:43:50 PST

> There is no need to reference these files from WebCore.gypi I've been told that there was a need - Chromium developers wanted these files in generated Xcode and MSVC project files for reference. I only have third hand information, and don't know who exactly wanted this.

Yury Semikhatsky

Comment 7 2012-11-26 00:04:35 PST

(In reply to comment #6) > > There is no need to reference these files from WebCore.gypi > > I've been told that there was a need - Chromium developers wanted these files in generated Xcode and MSVC project files for reference. I only have third hand information, and don't know who exactly wanted this. Yeah, as build bots showed Chromium depends on some of the win and mac files. But the rest still can be removed.

Alexey Proskuryakov

Comment 8 2012-11-26 08:40:34 PST

This is not what I said - it was not about not breaking the build, but about having the files in project for humans to easily access them. I don't have any opinion on whether it's desirable or not.

Adam Barth

Comment 9 2012-11-26 09:36:35 PST

> I don't have any opinion on whether it's desirable or not. IMHO, the cost of having the Windows build mysteriously break when a non-Chromium file is renamed is greater than any benefit folks get by having these files listed in the IDE.

Yury Semikhatsky

Comment 10 2013-03-26 06:12:30 PDT

Created attachment 195073 [details] Patch

Yury Semikhatsky

Comment 11 2013-03-26 06:20:11 PDT

Committed r146874: <http://trac.webkit.org/changeset/146874>

Note You need to log in before you can comment on or make changes to this bug.