Bug 103123

Summary: [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 103173    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch V3 none

Sudarsana Nagineni (babu)
Reported 2012-11-23 04:07:06 PST
Add support for PlatformWebView::simulateSpacebarKeyPress() and enable WebKit2 unit test that uses it.
Attachments
Patch (2.63 KB, patch)
2012-11-23 04:38 PST, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2012-11-23 04:51 PST, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Patch V3 (2.04 KB, patch)
2012-11-26 09:04 PST, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-11-23 04:38:31 PST
Created attachment 175780 [details] Patch
Sudarsana Nagineni (babu)
Comment 2 2012-11-23 04:51:25 PST
Created attachment 175782 [details] Patch Updated skip list.
Chris Dumez
Comment 3 2012-11-23 04:54:42 PST
Comment on attachment 175782 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2012-11-23 05:38:47 PST
Comment on attachment 175782 [details] Patch Clearing flags on attachment: 175782 Committed r135600: <http://trac.webkit.org/changeset/135600>
WebKit Review Bot
Comment 5 2012-11-23 05:38:51 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2012-11-24 02:46:21 PST
Re-opened since this is blocked by bug 103173
Sudarsana Nagineni (babu)
Comment 7 2012-11-26 09:03:06 PST
API test is passing on local machine, but it's failing on our bots due to the timing issue. Increasing the responsivenessTimeout helps in passing the test on bots also, but I think we don't need that change since the timing issue is only on our bots. Other API test(MouseMoveAfterCrash) is dependent on this functionality (bug #103252), so I am going to update the patch without unskipping the ResponsivenessTimerDoesntFireEarly test for now.
Sudarsana Nagineni (babu)
Comment 8 2012-11-26 09:04:23 PST
Created attachment 176013 [details] Patch V3
Laszlo Gombos
Comment 9 2012-11-28 07:31:50 PST
Comment on attachment 176013 [details] Patch V3 r=me.
WebKit Review Bot
Comment 10 2012-11-28 08:06:48 PST
Comment on attachment 176013 [details] Patch V3 Clearing flags on attachment: 176013 Committed r136011: <http://trac.webkit.org/changeset/136011>
WebKit Review Bot
Comment 11 2012-11-28 08:06:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.