Bug 103088

Summary: Remove SVGShadowText
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, fmalita, ojan, pdr, schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch rniwa: review+

Antti Koivisto
Reported 2012-11-22 13:02:46 PST
SVGShadowText subclass has little functionality beyond the plain Text. Remove it for simplicity.
Attachments
patch (5.50 KB, patch)
2012-11-22 14:03 PST, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-11-22 14:03:17 PST
Created attachment 175709 [details] patch
Ryosuke Niwa
Comment 2 2012-11-22 14:17:29 PST
Comment on attachment 175709 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=175709&action=review > Source/WebCore/dom/Text.cpp:242 > +static bool isSVGShadowText(Text* text) I would add inline if I were you. > Source/WebCore/dom/Text.cpp:248 > +static bool isSVGText(Text* text) Ditto. > Source/WebCore/svg/SVGTRefElement.cpp:162 > root->firstChild()->setTextContent(textContent, ASSERT_NO_EXCEPTION); We should probably assert that firstChild is a Text node.
Antti Koivisto
Comment 3 2012-11-22 14:48:25 PST
http://trac.webkit.org/changeset/135544
Note You need to log in before you can comment on or make changes to this bug.