Bug 103085

Summary: Get rid of HTMLCollectionCacheBase
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, eric, koivisto, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78909    
Attachments:
Description Flags
cleanup sam: review+, eflews.bot: commit-queue-

Ryosuke Niwa
Reported 2012-11-22 11:50:14 PST
HTMLCollectionCacheBase was introduced in http://trac.webkit.org/changeset/121580 in order to share more code between HTMLCollection and DynamicNodeList implementations. Now that we've merged two classes, this class is nothing but a hallow shell. Merge it into HTMLCollection.
Attachments
cleanup (10.57 KB, patch)
2012-11-22 12:00 PST, Ryosuke Niwa 		sam: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-11-22 12:00:10 PST
Created attachment 175698 [details] cleanup
Ryosuke Niwa
Comment 2 2012-11-22 12:04:11 PST
Comment on attachment 175698 [details] cleanup Thanks fort the timely review!
EFL EWS Bot
Comment 3 2012-11-22 12:06:06 PST
Comment on attachment 175698 [details] cleanup Attachment 175698 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14966446
Ryosuke Niwa
Comment 4 2012-11-22 12:07:01 PST
Committed r135534: <http://trac.webkit.org/changeset/135534>
Ryosuke Niwa
Comment 5 2012-11-22 12:20:13 PST
Build fix landed in http://trac.webkit.org/changeset/135535.
Eric Seidel (no email)
Comment 6 2012-11-23 06:57:48 PST
Thanks!
Note You need to log in before you can comment on or make changes to this bug.