Bug 103065

Summary: [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
Product: WebKit Reporter: Peter Beverloo <peter>
Component: New BugsAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100100    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Peter Beverloo
Reported 2012-11-22 06:21:38 PST
[Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
Attachments
Patch (4.53 KB, patch)
2012-11-22 06:24 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch (4.58 KB, patch)
2012-11-22 10:32 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.58 KB, patch)
2012-11-22 10:33 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-11-22 06:24:04 PST
Created attachment 175659 [details] Patch
Dirk Pranke
Comment 2 2012-11-22 10:29:53 PST
Comment on attachment 175659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175659&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:435 > + self._log_error('Unrecorgnized output from adb root: %s' % output) typo: "Unrecorgnized" :).
Peter Beverloo
Comment 3 2012-11-22 10:32:59 PST
Created attachment 175693 [details] Patch
Peter Beverloo
Comment 4 2012-11-22 10:33:46 PST
Created attachment 175694 [details] Patch for landing
Peter Beverloo
Comment 5 2012-11-22 10:34:36 PST
Comment on attachment 175694 [details] Patch for landing On Thanksgiving :-). Thank you very much for the review! The typo has been fixed.
WebKit Review Bot
Comment 6 2012-11-22 18:39:37 PST
Comment on attachment 175694 [details] Patch for landing Clearing flags on attachment: 175694 Committed r135552: <http://trac.webkit.org/changeset/135552>
WebKit Review Bot
Comment 7 2012-11-22 18:39:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.