Bug 103055

Summary: [WK2][EFL] No need to remove surface before replacing
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit EFLAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, mikhail.pozdnyakov, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
hausmann: review+
Image of resizing issue before patch none

Kenneth Rohde Christiansen
Reported 2012-11-22 04:48:54 PST
SSIA
Attachments
Patch (3.08 KB, patch)
2012-11-22 04:50 PST, Kenneth Rohde Christiansen 		hausmann: review+
DetailsFormatted DiffDiff
Image of resizing issue before patch (51.60 KB, image/png)
2012-11-22 04:52 PST, Kenneth Rohde Christiansen 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2012-11-22 04:50:14 PST
Created attachment 175648 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-11-22 04:52:45 PST
Created attachment 175649 [details] Image of resizing issue before patch
Kenneth Rohde Christiansen
Comment 3 2012-11-22 05:04:04 PST
You will notice that on resize we flicker and there is at least one frame with the old size.
Mikhail Pozdnyakov
Comment 4 2012-11-22 05:15:17 PST
[WK2] tag is missing in bug title.
Mikhail Pozdnyakov
Comment 5 2012-11-22 05:16:00 PST
Comment on attachment 175648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175648&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:391 > impl->createGLSurface(IntSize(width, height)); think it's better to rename this to resizeGLSurface
Chris Dumez
Comment 6 2012-11-22 05:18:40 PST
Comment on attachment 175648 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175648&action=review LGTM. >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:391 >> impl->createGLSurface(IntSize(width, height)); > > think it's better to rename this to resizeGLSurface No, I think the name is right. It is not technically resizing, it is creating a new surface with the new size. The previous surface is destroyed if existing.
Simon Hausmann
Comment 7 2012-11-22 05:49:20 PST
Comment on attachment 175648 [details] Patch rs=me
Kenneth Rohde Christiansen
Comment 8 2012-11-22 05:54:26 PST
Landed in 135514
Note You need to log in before you can comment on or make changes to this bug.