Bug 103038

Summary: Web Inspector: Simplify script mappings by introducing DefaultScriptMapping.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-11-22 01:47:07 PST
DefaultScriptMapping creates a uiSourceCode for each script and set itself as a mapping for the script. Script can now have a stack of (possibly disabled) mappings, allowing to try several mappings when calculating uiLocation. LiveEditSupport object is added on WebInspector to support live editing of readonly DefaultScriptMapping's uiSourceCodes. DefaultScriptMapping is now the only mapping that creates temporary uiSourceCodes.
Attachments
Patch (87.23 KB, patch)
2012-11-22 01:48 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (86.91 KB, patch)
2012-11-22 01:51 PST, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-11-22 01:48:55 PST
Created attachment 175623 [details] Patch
Vsevolod Vlasov
Comment 2 2012-11-22 01:51:21 PST
Created attachment 175625 [details] Patch
Pavel Feldman
Comment 3 2012-11-22 06:28:31 PST
Comment on attachment 175625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175625&action=review > Source/WebCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Remove this line. > Source/WebCore/inspector/front-end/DefaultScriptMapping.js:55 > + return new WebInspector.UILocation(uiSourceCode, lineNumber, columnNumber); We should finally make it a factory method on UISourceCode.
Vsevolod Vlasov
Comment 4 2012-12-27 03:22:16 PST
Committed r138496: <http://trac.webkit.org/changeset/138496>
Note You need to log in before you can comment on or make changes to this bug.