Bug 103038

Summary: Web Inspector: Simplify script mappings by introducing DefaultScriptMapping.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Vsevolod Vlasov 2012-11-22 01:47:07 PST 
DefaultScriptMapping creates a uiSourceCode for each script and set itself as a mapping for the script.
Script can now have a stack of (possibly disabled) mappings, allowing to try several mappings when calculating uiLocation.
LiveEditSupport object is added on WebInspector to support live editing of readonly DefaultScriptMapping's uiSourceCodes.
DefaultScriptMapping is now the only mapping that creates temporary uiSourceCodes.
Comment 1 Vsevolod Vlasov 2012-11-22 01:48:55 PST 
Created attachment 175623 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-11-22 01:51:21 PST 
Created attachment 175625 [details]
Patch
Comment 3 Pavel Feldman 2012-11-22 06:28:31 PST 
Comment on attachment 175625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175625&action=review

> Source/WebCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Remove this line.

> Source/WebCore/inspector/front-end/DefaultScriptMapping.js:55
> +        return new WebInspector.UILocation(uiSourceCode, lineNumber, columnNumber);

We should finally make it a factory method on UISourceCode.
Comment 4 Vsevolod Vlasov 2012-12-27 03:22:16 PST 
Committed r138496: <http://trac.webkit.org/changeset/138496>