Bug 103038 - Web Inspector: Simplify script mappings by introducing DefaultScriptMapping.
Summary: Web Inspector: Simplify script mappings by introducing DefaultScriptMapping.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
Depends on:
Reported: 2012-11-22 01:47 PST by Vsevolod Vlasov
Modified: 2012-12-27 03:22 PST (History)
8 users (show)

See Also:

Patch (87.23 KB, patch)
2012-11-22 01:48 PST, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (86.91 KB, patch)
2012-11-22 01:51 PST, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-11-22 01:47:07 PST
DefaultScriptMapping creates a uiSourceCode for each script and set itself as a mapping for the script.
Script can now have a stack of (possibly disabled) mappings, allowing to try several mappings when calculating uiLocation.
LiveEditSupport object is added on WebInspector to support live editing of readonly DefaultScriptMapping's uiSourceCodes.
DefaultScriptMapping is now the only mapping that creates temporary uiSourceCodes.
Comment 1 Vsevolod Vlasov 2012-11-22 01:48:55 PST
Created attachment 175623 [details]
Comment 2 Vsevolod Vlasov 2012-11-22 01:51:21 PST
Created attachment 175625 [details]
Comment 3 Pavel Feldman 2012-11-22 06:28:31 PST
Comment on attachment 175625 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=175625&action=review

> Source/WebCore/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

Remove this line.

> Source/WebCore/inspector/front-end/DefaultScriptMapping.js:55
> +        return new WebInspector.UILocation(uiSourceCode, lineNumber, columnNumber);

We should finally make it a factory method on UISourceCode.
Comment 4 Vsevolod Vlasov 2012-12-27 03:22:16 PST
Committed r138496: <http://trac.webkit.org/changeset/138496>