Bug 103011

Summary: listMarkerText() should create 8 bit strings when possible
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: Layout and RenderingAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gtk-ews, ojan, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
fpizlo: review+, eflews.bot: commit-queue-
Patch ith Speculative EFL build fix
eflews.bot: commit-queue-
Patch with speculative build fix for GTK and EFL none

Michael Saboff
Reported 2012-11-21 20:12:32 PST
listMarkerText() always creates and returns a 16 bit string. Most common marker types can represented by an 8 bit string.
Attachments
Patch (9.27 KB, patch)
2012-11-21 20:23 PST, Michael Saboff 		fpizlo: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch ith Speculative EFL build fix (9.47 KB, patch)
2012-11-21 21:44 PST, Michael Saboff 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch with speculative build fix for GTK and EFL (9.61 KB, patch)
2012-11-22 10:22 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-11-21 20:23:22 PST
Created attachment 175575 [details] Patch
EFL EWS Bot
Comment 2 2012-11-21 21:23:19 PST
Comment on attachment 175575 [details] Patch Attachment 175575 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14969210
Michael Saboff
Comment 3 2012-11-21 21:44:36 PST
Created attachment 175585 [details] Patch ith Speculative EFL build fix
EFL EWS Bot
Comment 4 2012-11-22 00:06:05 PST
Comment on attachment 175585 [details] Patch ith Speculative EFL build fix Attachment 175585 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14959241
Eric Seidel (no email)
Comment 5 2012-11-22 00:07:59 PST
LGTM.
kov's GTK+ EWS bot
Comment 6 2012-11-22 01:23:24 PST
Comment on attachment 175585 [details] Patch ith Speculative EFL build fix Attachment 175585 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14879872
Michael Saboff
Comment 7 2012-11-22 10:22:40 PST
Created attachment 175692 [details] Patch with speculative build fix for GTK and EFL Added a typedef to work around what appears to be a compiler defect taking the sizeof() a argument to a templates function.
Michael Saboff
Comment 8 2012-11-23 21:19:16 PST
Committed r135641: <http://trac.webkit.org/changeset/135641>
Note You need to log in before you can comment on or make changes to this bug.