Bug 103008

Summary: [WK2] Expose Accelerated2dCanvas flag set and get in WebKit2
Product: WebKit Reporter: Kyungjin Kim <gen.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dw.im, gyuyoung.kim, hyunki.baik, jesus, kenneth, laszlo.gombos, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch
none
patch_2D
none
patch_2D
none
patch_2D_rebase
none
Patch none

Kyungjin Kim
Reported 2012-11-21 19:04:45 PST
Add setting APIs for accelerated 2d canvas in WebKit2
Attachments
Patch (4.53 KB, patch)
2012-11-21 20:07 PST, Kyungjin Kim 		no flags
DetailsFormatted DiffDiff
patch_2D (2.47 KB, patch)
2012-11-27 02:09 PST, Kyungjin Kim 		no flags
DetailsFormatted DiffDiff
patch_2D (2.47 KB, patch)
2012-11-27 02:11 PST, Kyungjin Kim 		no flags
DetailsFormatted DiffDiff
patch_2D_rebase (2.47 KB, patch)
2012-11-27 02:30 PST, Kyungjin Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.69 KB, patch)
2012-11-27 02:44 PST, Kyungjin Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Kyungjin Kim
Comment 1 2012-11-21 20:07:39 PST
Created attachment 175571 [details] Patch
Gyuyoung Kim
Comment 2 2012-11-26 18:28:45 PST
Comment on attachment 175571 [details] Patch LGTM
WebKit Review Bot
Comment 3 2012-11-26 19:05:34 PST
Comment on attachment 175571 [details] Patch Clearing flags on attachment: 175571 Committed r135803: <http://trac.webkit.org/changeset/135803>
WebKit Review Bot
Comment 4 2012-11-26 19:05:40 PST
All reviewed patches have been landed. Closing bug.
Kenneth Rohde Christiansen
Comment 5 2012-11-27 01:10:59 PST
Comment on attachment 175571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175571&action=review > Source/WebKit2/ChangeLog:8 > + Add setting APIs for accelerated 2d canvas in WebKit2. 2D! > Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:451 > +void WKPreferencesSetAccelerated2dCanvasEnabled(WKPreferencesRef preferencesRef, bool flag) Please no it is called 2D and not 2d! Please fix asap. Especially in public api
Gyuyoung Kim
Comment 6 2012-11-27 01:53:57 PST
Comment on attachment 175571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175571&action=review >> Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:451 >> +void WKPreferencesSetAccelerated2dCanvasEnabled(WKPreferencesRef preferencesRef, bool flag) > > Please no it is called 2D and not 2d! Please fix asap. Especially in public api Other ports have used *2d* in WK1's APIs. So, I accepted this. However, I also think 2D is correct in WK2 C API level. Sorry.
Kyungjin Kim
Comment 7 2012-11-27 02:09:08 PST
Created attachment 176205 [details] patch_2D
Kyungjin Kim
Comment 8 2012-11-27 02:11:50 PST
Created attachment 176206 [details] patch_2D
Kyungjin Kim
Comment 9 2012-11-27 02:30:07 PST
Created attachment 176211 [details] patch_2D_rebase
Kyungjin Kim
Comment 10 2012-11-27 02:44:53 PST
Reopening to attach new patch.
Kyungjin Kim
Comment 11 2012-11-27 02:44:58 PST
Created attachment 176215 [details] Patch
Kyungjin Kim
Comment 12 2012-11-27 02:50:09 PST
*** Bug 103380 has been marked as a duplicate of this bug. ***
WebKit Review Bot
Comment 13 2012-11-27 03:21:22 PST
Comment on attachment 176215 [details] Patch Clearing flags on attachment: 176215 Committed r135843: <http://trac.webkit.org/changeset/135843>
WebKit Review Bot
Comment 14 2012-11-27 03:21:27 PST
All reviewed patches have been landed. Closing bug.
Jesus Sanchez-Palencia
Comment 15 2012-11-27 10:54:05 PST
(In reply to comment #3) > (From update of attachment 175571 [details]) > Clearing flags on attachment: 175571 > > Committed r135803: <http://trac.webkit.org/changeset/135803> Just out of curiosity, is there an implementation of this somewhere? (not only the preference flag, I mean...)
Kyungjin Kim
Comment 16 2012-11-27 17:37:10 PST
(In reply to comment #15) > (In reply to comment #3) > > (From update of attachment 175571 [details] [details]) > > Clearing flags on attachment: 175571 > > > > Committed r135803: <http://trac.webkit.org/changeset/135803> > > Just out of curiosity, is there an implementation of this somewhere? (not only the preference flag, I mean...) it will be uploaded within a few days..
Note You need to log in before you can comment on or make changes to this bug.