Bug 102988

Summary: [EFL] Remove unnecessary definition, -DENABLE_SPELLCHECK=1
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryuan Choi
Reported 2012-11-21 16:18:13 PST
cmakeconfig.h already defines it when enabled.
Attachments
Patch (1.07 KB, patch)
2012-11-21 16:20 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.12 KB, patch)
2012-11-21 16:22 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (1.13 KB, patch)
2012-11-21 19:17 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2012-11-21 16:20:12 PST
Created attachment 175544 [details] Patch
Ryuan Choi
Comment 2 2012-11-21 16:22:55 PST
Created attachment 175545 [details] Patch
Laszlo Gombos
Comment 3 2012-11-21 18:28:07 PST
Comment on attachment 175545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175545&action=review > ChangeLog:8 > + Removed -DENABLE_SPELLCHECK=1 because it is already defined by cmakeconfig.h cmakeconfig.h seems to be generated. Did you mean OptionsEfl.cmake ?
Ryuan Choi
Comment 4 2012-11-21 19:17:45 PST
Created attachment 175568 [details] Patch
Laszlo Gombos
Comment 5 2012-11-21 19:19:59 PST
Comment on attachment 175568 [details] Patch r=me.
Ryuan Choi
Comment 6 2012-11-21 22:19:31 PST
Committed r135477: <http://trac.webkit.org/changeset/135477>
Note You need to log in before you can comment on or make changes to this bug.