Bug 102959

Summary: REGRESSION(r135409): This patch causes compiling error to Chromium build (Requested by jianli_ on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: jianli, jochen
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 102941    
Attachments:
Description Flags
ROLLOUT of r135409 none

WebKit Review Bot
Reported 2012-11-21 10:13:56 PST
http://trac.webkit.org/changeset/135409 broke the build: This patch causes compiling error to Chromium build (Requested by jianli_ on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r135409 (3.56 KB, patch)
2012-11-21 10:14 PST, WebKit Review Bot
no flags
WebKit Review Bot
Comment 1 2012-11-21 10:14:36 PST
Created attachment 175474 [details] ROLLOUT of r135409 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Jian Li
Comment 2 2012-11-21 10:17:24 PST
Here is the error: Undefined symbols: "__ZN6WebKit16FrameTestHelpers20createWebViewAndLoadERKSsbPNS_14WebFrameClientEPNS_13WebViewClientE", referenced from: __ZN12_GLOBAL__N_114IDBRequestTest5SetUpEv in IDBRequestTest.o http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/17133
WebKit Review Bot
Comment 3 2012-11-21 10:20:57 PST
Comment on attachment 175474 [details] ROLLOUT of r135409 Clearing flags on attachment: 175474 Committed r135415: <http://trac.webkit.org/changeset/135415>
WebKit Review Bot
Comment 4 2012-11-21 10:21:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.