Bug 102952 – [chromium] Make use_default_render_theme compile the right set of files

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Scott Violet]

Additionally need to copy public/linux/WebRenderTheme to public/default.

[Scott Violet]

Created attachment 175522 [details]
Patch

[Scott Violet]

WebKit DEPS was rolled, so this compiles for me outside of chrome.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Tony Chang]

Comment on attachment 175522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175522&action=review

LGTM

> Source/WebKit/chromium/WebKit.gyp:853
> +                }],
> +                ['use_default_render_theme==0', {

Nit: I would make this an else clause (delete from ] to the second ' inclusive).

[Scott Violet]

Created attachment 175528 [details]
Patch

[Scott Violet]

Newest patch converts to else syntax as outlined in comment 4.

[Kent Tamura]

Comment on attachment 175528 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 175528 [details]
Patch

Clearing flags on attachment: 175528

Committed r135718: <http://trac.webkit.org/changeset/135718>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.