Bug 102950

Summary: Replace NodeRendererFactory class with a function
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, kling, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
kling: review+
patch 2 kling: review+, koivisto: commit-queue-

Antti Koivisto
Reported 2012-11-21 09:22:42 PST
It is an unnecessary abstraction.
Attachments
patch (9.18 KB, patch)
2012-11-21 09:28 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
patch 2 (9.56 KB, patch)
2012-11-21 10:05 PST, Antti Koivisto 		kling: review+
koivisto: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-11-21 09:28:00 PST
Created attachment 175462 [details] patch
Andreas Kling
Comment 2 2012-11-21 09:52:32 PST
Comment on attachment 175462 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=175462&action=review > Source/WebCore/dom/NodeRenderingContext.h:61 > + const RenderStyle* style() const; Yay const!
Antti Koivisto
Comment 3 2012-11-21 10:05:54 PST
Created attachment 175472 [details] patch 2
WebKit Review Bot
Comment 4 2012-11-21 10:09:33 PST
Comment on attachment 175472 [details] patch 2 Rejecting attachment 175472 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14965016
Antti Koivisto
Comment 5 2012-11-21 11:00:35 PST
http://trac.webkit.org/changeset/135419
Note You need to log in before you can comment on or make changes to this bug.