Bug 102950 - Replace NodeRendererFactory class with a function
Summary: Replace NodeRendererFactory class with a function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-21 09:22 PST by Antti Koivisto
Modified: 2012-11-21 11:00 PST (History)
4 users (show)

See Also:

Attachments
patch (9.18 KB, patch)
2012-11-21 09:28 PST, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
patch 2 (9.56 KB, patch)
2012-11-21 10:05 PST, Antti Koivisto 		kling: review+
koivisto: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-11-21 09:22:42 PST 
It is an unnecessary abstraction.
Comment 1 Antti Koivisto 2012-11-21 09:28:00 PST 
Created attachment 175462 [details]
patch
Comment 2 Andreas Kling 2012-11-21 09:52:32 PST 
Comment on attachment 175462 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175462&action=review

> Source/WebCore/dom/NodeRenderingContext.h:61
> +    const RenderStyle* style() const;

Yay const!
Comment 3 Antti Koivisto 2012-11-21 10:05:54 PST 
Created attachment 175472 [details]
patch 2
Comment 4 WebKit Review Bot 2012-11-21 10:09:33 PST 
Comment on attachment 175472 [details]
patch 2

Rejecting attachment 175472 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14965016
Comment 5 Antti Koivisto 2012-11-21 11:00:35 PST 
http://trac.webkit.org/changeset/135419