Bug 102941

Summary: IDBRequestTest needs a v8 context
Product: WebKit Reporter: Dan Carney <dcarney>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 102959    
Bug Blocks: 101573    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Dan Carney
Reported 2012-11-21 07:29:24 PST
IDBRequestTest needs a v8 context
Attachments
Patch (3.46 KB, patch)
2012-11-21 07:30 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (3.68 KB, patch)
2012-11-21 07:55 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (4.41 KB, patch)
2012-11-22 00:35 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dan Carney
Comment 1 2012-11-21 07:30:21 PST
Created attachment 175441 [details] Patch
jochen
Comment 2 2012-11-21 07:37:04 PST
Comment on attachment 175441 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=175441&action=review > Source/WebKit/chromium/tests/IDBRequestTest.cpp:68 > + v8::Handle<v8::Context> context() can you call this v8Context() so it doesn't collide with the variables named "context" in the test?
Dan Carney
Comment 3 2012-11-21 07:55:00 PST
Created attachment 175447 [details] Patch
WebKit Review Bot
Comment 4 2012-11-21 09:17:49 PST
Comment on attachment 175447 [details] Patch Clearing flags on attachment: 175447 Committed r135409: <http://trac.webkit.org/changeset/135409>
WebKit Review Bot
Comment 5 2012-11-21 09:17:52 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2012-11-21 10:13:59 PST
Re-opened since this is blocked by bug 102959
Dan Carney
Comment 7 2012-11-22 00:35:34 PST
Created attachment 175608 [details] Patch
Dan Carney
Comment 8 2012-11-22 01:21:04 PST
Comment on attachment 175608 [details] Patch now with mac support
WebKit Review Bot
Comment 9 2012-11-22 05:17:29 PST
Comment on attachment 175608 [details] Patch Clearing flags on attachment: 175608 Committed r135506: <http://trac.webkit.org/changeset/135506>
WebKit Review Bot
Comment 10 2012-11-22 05:17:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.