Bug 102886

Summary: HTMLCollection should use the same storage as DynamicNodeList
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, darin, eric, koivisto, mifenton, ojan, philn, tkent, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 78909    
Attachments:
Description Flags
cleanup
none
Fixed GTK+ & FEL builds koivisto: review+, eflews.bot: commit-queue-

Ryosuke Niwa
Reported 2012-11-20 23:39:06 PST
HTMLCollection should use the same storage as DynamicNodeList
Attachments
cleanup (18.28 KB, patch)
2012-11-20 23:42 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed GTK+ & FEL builds (18.98 KB, patch)
2012-11-21 12:59 PST, Ryosuke Niwa 		koivisto: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-11-20 23:42:41 PST
Created attachment 175348 [details] cleanup
EFL EWS Bot
Comment 2 2012-11-20 23:50:31 PST
Comment on attachment 175348 [details] cleanup Attachment 175348 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14901855
Ryosuke Niwa
Comment 3 2012-11-21 12:59:22 PST
Created attachment 175502 [details] Fixed GTK+ & FEL builds
Antti Koivisto
Comment 4 2012-11-21 13:05:48 PST
Comment on attachment 175502 [details] Fixed GTK+ & FEL builds View in context: https://bugs.webkit.org/attachment.cgi?id=175502&action=review r=me > Source/WebCore/dom/NodeRareData.h:82 > + NodeListAtomicNameCacheMap::AddResult result = m_atomicNameCaches.add( > + namedNodeListKey(DynamicNodeList::PastLastNodeListType + collectionType - FirstNodeCollectionType, starAtom), 0); This spills awkwardly to the next line. You should just construct the key on a separate line. > Source/WebCore/dom/NodeRareData.h:94 > + return static_cast<T*>(m_atomicNameCaches.get(namedNodeListKey(DynamicNodeList::PastLastNodeListType + type - FirstNodeCollectionType, starAtom))); This is pretty long too.
EFL EWS Bot
Comment 5 2012-11-21 13:22:49 PST
Comment on attachment 175502 [details] Fixed GTK+ & FEL builds Attachment 175502 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14950119
Ryosuke Niwa
Comment 6 2012-11-21 13:38:57 PST
Committed r135429: <http://trac.webkit.org/changeset/135429>
Ryosuke Niwa
Comment 7 2012-11-21 14:03:53 PST
One more build fix for EFL & GTK+ landed in http://trac.webkit.org/changeset/135431.
Eric Seidel (no email)
Comment 8 2012-11-22 00:14:24 PST
Curious what (if any) memory/perf effects this is expected to have.
Ryosuke Niwa
Comment 9 2012-11-22 01:15:10 PST
It shouldn't have any.
Note You need to log in before you can comment on or make changes to this bug.